adds keep-alive-interval to repair QUIC transport config #33866
Conversation
behzadnouri
force-pushed
the
repair-quic-config
branch
from
ea70d31
to
3b35ea0
Compare
Codecov Report
@@ Coverage Diff @@
## master #33866 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 811 811
Lines 219356 219359 +3
=======================================
+ Hits 179732 179735 +3
Misses 39624 39624 |
| const MAX_CONCURRENT_BIDI_STREAMS: VarInt = VarInt::from_u32(512); | ||
| const MAX_IDLE_TIMEOUT: Duration = Duration::from_secs(10); |
There was a problem hiding this comment.
I see definitions for these in sdk/src/quic.rs. Can you add comments about why new definitions are needed?
There was a problem hiding this comment.
The ones in sdk are used for tpu, which has very different properties than repair. In particular tpu packets are only forwarded to the upcoming leaders which we know in advance who they are, it is a uni-directional traffic, and has a very different load and latency tolerance. Repair is bi-directional request-response, peers are randomly sampled, etc.
I pretty much rather not to reuse the same parameters at this stage until this code is stable and repair over quic protocol is fully rolled out over mainnet. Until then reusing same parameters can introduce regressions on one protocol while trying to optimize another protocol.
There was a problem hiding this comment.
I think just add some code comments on the reasoning will help.
| let mut config = TransportConfig::default(); | ||
| config | ||
| .datagram_receive_buffer_size(None) |
There was a problem hiding this comment.
Comment this to disable datagrams?
behzadnouri
force-pushed
the
repair-quic-config
branch
from
3b35ea0
to
fe866f3
Compare
QUIC connections may timeout due to infrequent repair requests. The commit configures keep_alive_interval and max_idle_timeout to avoid timeouts. (cherry picked from commit 3ac2507)
…port of #33866) (#33992) adds keep-alive-interval to repair QUIC transport config (#33866) QUIC connections may timeout due to infrequent repair requests. The commit configures keep_alive_interval and max_idle_timeout to avoid timeouts. (cherry picked from commit 3ac2507) Co-authored-by: behzad nouri <[email protected]>
…port of solana-labs#33866) (solana-labs#33992) adds keep-alive-interval to repair QUIC transport config (solana-labs#33866) QUIC connections may timeout due to infrequent repair requests. The commit configures keep_alive_interval and max_idle_timeout to avoid timeouts. (cherry picked from commit 3ac2507) Co-authored-by: behzad nouri <[email protected]>
…port of solana-labs#33866) (solana-labs#33992) adds keep-alive-interval to repair QUIC transport config (solana-labs#33866) QUIC connections may timeout due to infrequent repair requests. The commit configures keep_alive_interval and max_idle_timeout to avoid timeouts. (cherry picked from commit 3ac2507) Co-authored-by: behzad nouri <[email protected]>
Problem
QUIC connections timeout due to infrequent repair requests.
Summary of Changes
Added
keep_alive_intervalto transport config.